search

occ-ai / obs-localvocal

OBS plugin for local speech recognition and captioning using AI
https://obsproject.com/forum/resources/localvocal-live-stream-ai-assistant.1769/
GNU General Public License v2.0
359 stars 28 forks source link

fix: fix obs crash when use 7.1 channel #74

Closed A0nameless0man closed 4 months ago

A0nameless0man commented 4 months ago

Fix #73

A0nameless0man commented 4 months ago

https://github.com/occ-ai/obs-localvocal/blob/240f7dd817efae0cbce99bfcf98d4aeca8742b2e/src/transcription-filter.cpp#L104-L107

royshil commented 4 months ago

@A0nameless0man does this solve the crash for you? i also wonder why no one else ran into the problem

A0nameless0man commented 4 months ago

I'm reverting other changes I made to verify that this is the only patch needed for my problem.

I assume that stream or record in 7.1 is a niche activity.

A0nameless0man commented 4 months ago

Confirmed, this patch alone can fix my problem.

royshil commented 4 months ago

Cool. In general this checks out However there are build problems that are unrelated to your patch

So I think I'll have to bring up a PR fixing this and other things.

royshil commented 4 months ago

@A0nameless0man plz see #75