search

occ / TraceKit

Attempts to create stack traces for unhandled JavaScript exceptions in all major browsers.
1.06k stars 70 forks source link

Remove remote fetching and analyzing? #25

Closed devinrhode2 closed 11 years ago

devinrhode2 commented 11 years ago

I don't like the idea of TraceKit making a request for my js file to provide lines of context when it's almost no different than just getting the straight line number of the error.

I'm proposing we remove all operations dealing with requesting a remote file and analyzing it.

Related to #11, testing becomes tricky

devinrhode2 commented 11 years ago

What do you think @airportyh?

airportyh commented 11 years ago

But from what I understand, remote source fetching is a big component of TraceKit. It is what makes stacktraces work in IE, for example, which I think is actually very nifty.

airportyh commented 11 years ago

Oh, and I just realized this won't help the fact that evaling breaks stacktraces - no location or lineno info.

occ commented 11 years ago

Remote fetching is an important part of tracekit. I don't think removing it would be a good idea. I do support having/improving the "do not fetch" flag though.