search

occ / TraceKit

Attempts to create stack traces for unhandled JavaScript exceptions in all major browsers.
1.06k stars 70 forks source link

firefox .columnNumber support? #53

Closed acthp closed 9 years ago

acthp commented 11 years ago

I see in the code comments that an "unreliable column number" is supported in firefox, though it looks like it attempts this by doing a string match. I guess that's the unreliable part. With compressed code, I've never seen it return a value. Why not use error.columnNumber, which reports the column number of the first frame?

acthp commented 11 years ago

Ugh. The columnNumber from ff is, well, unreliable. ;) I filed a bug against it, which has been confirmed by the mozilla project. I have a faint hope that there might be a workaround. In very small examples, ff can be coerced to report accurate columnNumbers by appending "var a;" to the js file. However this doesn't appear to work for large files, generated with uglify2.

rakeshpai commented 11 years ago

@acthp Do you have a link to the bug report, please? TIA.

acthp commented 11 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=935743

niemyjski commented 9 years ago

@acthpI'm helping maintain TraceKit upstream.. If you want to recreate this issue in the master (https://github.com/csnover/TraceKit) That would be greatly appreciated.

niemyjski commented 9 years ago

This now happens in the latest release on https://github.com/csnover/TraceKit

devinrhode2 commented 9 years ago

Nice job Blake!

-Devin http://zerply.com/DevinRhode2 http://zerply.com/devinrhode2

On Sun, May 17, 2015 at 7:14 PM, Blake Niemyjski notifications@github.com wrote:

This now happens in the latest release on https://github.com/csnover/TraceKit

— Reply to this email directly or view it on GitHub https://github.com/occ/TraceKit/issues/53#issuecomment-102892289.