search

occ / TraceKit

Attempts to create stack traces for unhandled JavaScript exceptions in all major browsers.
1.06k stars 70 forks source link

Expose getSource as TraceKit.computeStackTrace.getSource #71

Closed rhoggSugarcrm closed 9 years ago

rhoggSugarcrm commented 9 years ago

Hi @occ, this commit is necessary to enable sharing of the source code cache between TraceKit and other running code.

niemyjski commented 9 years ago

@rhoggSugarcrm, I'm helping manage the TraceKit project. Can you please create a pull request for this here https://github.com/csnover/TraceKit so we can get it merged in. Also do you have a use case for this?

rwhogg commented 9 years ago

Hey @niemyjski - I'm rhoggSugarcrm, but that account is managed by my employer (I'm currently in-between internships; I'll be returning to them in September, at which point I can resume using that account)

I can definitely make a pull request tomorrow! Sorry for not responding until now; I no longer get notifications for rhoggSugarcrm.

As for my use case: I'm using TraceKit and mozilla/source-map in concert for sending stack traces to a server. I need to AJAX the source files in order to look up their source map (so I can send original, rather than minified, line numbers in those stack traces.) Sharing the cache just cuts down on the number of HTTP requests I need to make.

rwhogg commented 9 years ago

@niemyjski I created https://github.com/csnover/TraceKit/pull/15 against your repo. While I don't think it's completely ready for merge yet (I might need to write a test) it's at least against the canonical repo now.

@occ could you close this PR please? I can't do it myself since I won't have access to my SugarCRM account for several months.

niemyjski commented 9 years ago

Thank you so much for your explanation! Did you have to do a custom version of mozilla/source-map to get them to work together... I've been wanting to do an optional build of tracekit that contains source map support.

rwhogg commented 9 years ago

No, I didn't need to make any changes to source-map. I just used their most recent (at the time of download) Github master.