search

occam-ra / occam

OCCAM Reconstructability Analysis Tools
Other
20 stars 14 forks source link

Take PSU-branded stuff out of web front pages. #5

Closed gdcutting closed 5 years ago

gdcutting commented 5 years ago

Currently there is some Portland State branding in the front (HTML) files. Go through and figure out how to take this out so we're no longer enforcing the appearance from dmm.sysc.pdx.edu.

Gooseus commented 5 years ago

I think this may be wrapped up in a greater issue of replacing the web interface altogether.

I'm not sure where that would be on the project roadmap or if we'd want to remove branding sooner as an isolated task?

BartMassey commented 5 years ago

Remove the branding first, I think. PSU will get really antsy if they find out we've been distributing their branding. Also it's a great opportunity to advertise OCCAM per se with a generic OCCAM frontend that many folks won't bother to replace.

gdcutting commented 5 years ago

Not sure this was entirely fixed? Reopening for now.

Gooseus commented 5 years ago

@gdcutting What isn't fixed?

gdcutting commented 5 years ago

Just seemed like changes you made to gooseus/remove-psu had not yet been merged upstream into main repo. Like if someone installed from occam-ra/occam master they would still get the PSU stuff.

Gooseus commented 5 years ago

I just double checked the HTML in master branch and it looks like the changes I had made to remove-psu are there... I'll be honest, I didn't do a fresh install to check, but I was pretty confident since I did do the make web and check on an existing install.

https://github.com/occam-ra/occam/blob/master/html/header.html

https://github.com/occam-ra/occam/blob/master/html/index.html

If you look at the commit history for those files you'll see all the changes I made to remove the PSU branding.

Did you do an install from the master branch and not see these changes?

gdcutting commented 5 years ago

I was just still seeing PSU-related mentions in the HTML/css but realized the visual is fine now because the PSU header image is gone. Will need a little more further cleanup at some point probably but can close for now. Thanks