occipital / django-content-settings

The most advanced admin editable setting for Django
https://django-content-settings.readthedocs.io/
39 stars 0 forks source link

Django convention - use "help_text=" instead of "help=" #61

Closed richardbrockie closed 9 months ago

richardbrockie commented 9 months ago

The Django convention in model fields and other places is to use "help_text=", for example: https://docs.djangoproject.com/en/5.0/ref/models/fields/#help-text

My suggestion is that django-content-settings uses the same as Django has me well trained.

oduvan commented 9 months ago

That makes sense.

One more issue with help attribute, it actually acceps html, not text.

so the fix itself should include support only text, support both attributes and depreciation warning.

oduvan commented 9 months ago

thank you for the good catch

richardbrockie commented 9 months ago

That makes sense.

One more issue with help attribute, it actually acceps html, not text.

so the fix itself should include support only text, support both attributes and depreciation warning.

Django help_text= accepts html - I use the occasional <br /> for line breaks in long comments.

oduvan commented 9 months ago

will be released in 0.10.1