occitech / docker

Docker images we use at Occitech
31 stars 36 forks source link

run.sh misses hosts with similar IP addresses #29

Closed redlegoman closed 3 years ago

redlegoman commented 3 years ago

munin: I added two hosts to the NODES variable with IP addresses 10.10.10.150 and 10.10.10.15. The run.sh script greps the IP in munin.conf before adding, to make sure it does not duplicate entries, but grepping for "10.10.10.15" matches "10.10.10.150", so it does not add 10.10.10.15 unless you rearrange the NODES list or change the grep in run.sh to something like: grep -q "${HOST}$" /etc/munin/munin.conf || cat << EOF >> /etc/munin/munin.conf