Add chapter-view script

occivink / mpv-gallery-view

Gallery-view scripts for mpv

The Unlicense

189 stars 20 forks source link

Add chapter-view script #27

Closed po5 closed 3 years ago

po5 commented 3 years ago

Most of the code is the same as contact-sheet, with some notable differences:

A thumbnail is displayed for each chapter, the item title is either the chapter title or it's position if it doesn't have a title.
The time at which the thumbnail is taken isn't necessarily the one displayed, there is a default offset of 2 seconds (to deal with fades from black). Cached filenames contain the effective thumbnail time.

occivink commented 3 years ago

That's a nice idea, but I think I would prefer having this as a config in contact-sheet. I'm already not a big fan of the duplication I have in the two scripts.

po5 commented 3 years ago

Indeed, some module stuff could be moved into gallery.lua to cut down on duplication. Figured it's fine for now as solving that problem would require a lot of edits to all scripts and the structure of the code, needs its own PR.

occivink commented 3 years ago

Yeah, I'm not saying to extend the scope of this PR to cutting down the duplication, but I would like chapter-view and contact-sheet to be merged in one script at least.

occivink commented 3 years ago

I've now added a chapter mode to the contact-sheet script, I tried to keep the options you had. Thanks for the idea.