Closed N-R-K closed 2 years ago
@occivink Hi, have you forgotten about/not noticed this PR or simply don't like it? If it's the latter then I can close it.
Hello,
I think the part about the ramdisk makes sense. I had originally not done this because there's no easy cross-platform way to do it as far as I could tell (even if I don't use windows myself, it doesn't hurt to keep compatibility), but maybe mkdir
is compatible enough.
Could you replace the os.execute
calls with utils.subprocess
? That way there is no issue with escaping of special characters.
Hi, I did have windows compatibility in mind even though I don't use it myself either. Afaik windows also has mkdir
and so it should work, though I'm unsure weather it has the -p
flag or not so I left that out.
Thanks, and sorry for the delay
disabled by default. this will allow users who are using ramdisk as thumbs_dir to not have to manually create that directory after every reboot.
i had this hardcoded for myself for a good while, but i don't see why this shouldn't be upstreamed.