occivink / mpv-gallery-view

Gallery-view scripts for mpv
The Unlicense
189 stars 20 forks source link

Change Unix default thumbnail directory #37

Closed microraptor closed 2 years ago

microraptor commented 2 years ago

This PR only changes the default Unix directory from ~/.mpv_thumbs_dir/ to ~/.cache/thumbnails/mpv-gallery. The majority of graphical Linux systems in use store their thumbnails at ~/.cache/thumbnails/ and it makes sense to have a folder for this script their as well. Users who clean their thumbnail caches regularly probably don't have to adjust anything to clean this folder too.

occivink commented 2 years ago

I'm ok with this change. Could you squash all these commits into one?

microraptor commented 2 years ago

Sorry about that. I did the changes on Github's Web UI, which doesn't seem to have squashing. You can actually squash the PR at your end though: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests

Otherwise let me know and I will do the squashing with a local checkout.

microraptor commented 2 years ago

I did a local squash now anyways