occivink
commented
5 years ago I just tried it with master and it works as expected. You may be right with your guess that the 'complex' key binding is not fully reported, the manual mentions that it's a possibility (https://mpv.io/manual/master/#lua-scripting-complex). Which platform are you on?
Actually judging by the symptoms it looks like it's the mouse_move keybinding that does not work, but it's used by the osc so I can't imagine that being not reliable.
Can you try this short script, and report what it prints to the console? Just move the mouse around and press the right mouse button.
utils = require "mp.utils"
mp.add_forced_key_binding("mouse_move", "test_move", function()
print(mp.get_mouse_pos())
end)
mp.add_forced_key_binding("MBTN_RIGHT", "test_press", function(event)
print(utils.format_json(event))
end, {complex=true})
jgreco
0ion9
sammoth
dumblob
butteria
I have drag-to-pan bound as suggested in input.conf:
MBTN_RIGHT script-binding image-viewer/drag-to-panUsually this binding does not work -- ie. rightclicking or rightdragging doesn't do anything visible. However, operating the mousewheel to zoom in/out and then quickly rightdragging allows drag-to-pan to work. After that one operation, I must again perform the mousewheel -> drag dance if I want to pan again.
My conclusion is that cursor-centric-zoom (or a sideeffect of it) sets some part of mpv state in a way that allows drag-to-pan to work, but this state 'times out' (maybe something that is automatically reset by MPV). Reading the code, the only idea that occurs to me is the table["event"] == "down" check.
'pan follows cursor', which makes the same check, doesn't appear to work correctly, but fails in a slightly different, more usable way (it works as a oneshot operation that, as soon as the click comes in, takes the relative mouse position within the window as the point within the image to pan to, eg. clicking 0,0 in the window pans to the top left of image and the operation immediately ends)
MPV event API has changed in some subtle way, perhaps?
EDIT: it's also worth noting that other mpv scripts using dragging work completely normally -- eg, mpv_crop_script. I haven't yet found another script that tries to bind dragging directly (rather than within a distinct mode), but if you know of one, I'm happy to test it.
EDIT2: You'd think that 'window-dragging' might impact this, but window-dragging=yes or no, neither have any effect on the problem.
EDIT3: That's enough debugging for a bit. My current best guess is that there is some other valid state for table["event"] that should be caught.
mpv version: 0.29.0-75-gda1073c247