search

occivink / mpv-scripts

Various scripts for mpv
The Unlicense
436 stars 40 forks source link

Cannot crop with hwdecoding #42

Open AeliusSaionji opened 4 years ago

AeliusSaionji commented 4 years ago

Hello!

Recently updated and noticed you now forcibly disable cropping when hwdecoding is active. While you may not be able to see the effect of your crop in real time, this did in fact work when cropping a video for encode.lua.

Could we exchange the hard-stop for an OSD notice instead?

Thank you!

UserNaem commented 4 years ago

Use the copy-back version of your hardware decoding method (i.e. hwdec=dxva2-copy instead of hwdec=dxva2) if you need filters, regular hardware decoding typically doesn't allow the use of filters.

AeliusSaionji commented 4 years ago

You missed the point of my post- I will repeat with emphasis in case it wasn't clear.

I use crop almost exclusively with encode.lua, which passes the crop along to ffmpeg. ffmpeg does not care if mpv used hwdec. The only downside to having hwdec enabled is that you cannot preview your crop before passing it along to ffmpeg. That's fine, imo. I'd rather have an error "cannot preview crop with hwdec" than a hard stop on the feature.