occivink / mpv-scripts

Various scripts for mpv
The Unlicense
417 stars 38 forks source link

Disable hardware decoding when using blur_edges #44

Open Nudin opened 3 years ago

Nudin commented 3 years ago

Hardware decoding will most often interfer with the filter, therefore disable it when enabling of blur_edges and restore the original value when disabling.

If you think it would be better to implement this feature as an opt-in/opt-out feature let me know.

occivink commented 3 years ago

I think it would make sense to make this behavior configurable, and simply just warn and abort by default. If I remember correctly, filters can also be used with all the *-copy hardware decoders.

Nudin commented 3 years ago

If I remember correctly, filters can also be used with all the *-copy hardware decoders.

At least on my system it also doesn't work with the -copy versions.

I made it configurable and documented it in the config file. I mad it enable by default, since if it is set to false the script will likely not work for several users, without any benefit.

shibotto commented 3 years ago

This would be very nice to have for crop.lua as well.