occivink / mpv-scripts

Various scripts for mpv
The Unlicense
420 stars 38 forks source link

blur-edges makes mpv stop working with resume-playback #9

Open CamilleScholtz opened 6 years ago

CamilleScholtz commented 6 years ago

After launching a video (using blur-edges) for the second time (so it resumes from previous playback) only the audio starts playing, no window appears. Also no errors at all.

occivink commented 6 years ago

I'll look into it, but I'm pretty sure that it's "just" the video track that gets unselected. You can work around that by pressing _ for now.

occivink commented 6 years ago

So what's happening is that to use the video in a "lavfi_complex" filter, we must first unselect it (by setting vid=no). Then, when quitting, watch_later remembers that we modified this option and writes it in the file. You can see that easily by opening the watch_later file corresponding to your video.

I tried different ways of restoring the video track just before exit, but these happen after the watch_later file has been written to.

Right now the only way I see is to add some logic to reset the video track when opening a file for which it is unselected. It's not a super satisfying fix, though.

occivink commented 6 years ago

This should be fixed as of https://github.com/mpv-player/mpv/commit/07c54d8c5ca0388cd9466438c09d380e32c13183, you'll have to compile mpv from git or wait for the next release.

CamilleScholtz commented 6 years ago

I'm using mpv git now and it's still not working :(

mpv ed73ba8 Copyright © 2000-2018 mpv/MPlayer/mplayer2 projects
 built on Sat Mar  3 15:39:24 CET 2018
ffmpeg library versions:
   libavutil       56.8.100
   libavcodec      58.13.102
   libavformat     58.10.100
   libswscale      5.0.102
   libavfilter     7.12.100
   libswresample   3.0.101
ffmpeg version: git-2018-03-03-e45d557
occivink commented 6 years ago

Right sorry, I was testing with local changes that I ended up not pushing. Since the change in question breaks the script on older versions of mpv, I've put it behind a config option: https://github.com/occivink/mpv-scripts/blob/master/lua-settings/blur_edges.conf#L21-L23