ocean-data-factory-sweden / kso

Notebooks to upload/download marine footage, connect to a citizen science project, train machine learning models and publish marine biological observations.
GNU General Public License v3.0
4 stars 12 forks source link

Ci pipeline complete #235

Closed Diewertje11 closed 10 months ago

Diewertje11 commented 11 months ago

This resolves issue #231. In the old workflow, the docker was build with the requirements from master, but the tests were run in a clone of the branch of the push/PR was made from, with a different version of ffmpeg than the container had. In this way we did not test if the code actually runs in the container.

The logic of this workflow is:

This results in that the dev or master docker image only gets updated on a push, independent on if the tests pass/fail during that push. (That they will pas should be checked first in a PR). The dev image only gets updated if the requirements/Docker file changed in the push. The master image always gets updated, since we want to have the new version of code available for the users on SNIC. (See issue #234)

Further improvements to the pipeline and the docker files are mentioned in issue #233.