search

ocean-data-factory-sweden / kso

Notebooks to upload/download marine footage, connect to a citizen science project, train machine learning models and publish marine biological observations.
GNU General Public License v3.0
4 stars 12 forks source link

Clean unused "add_project" func #259

Closed victor-wildlife closed 7 months ago

victor-wildlife commented 9 months ago

The "add_project" function (in project_utils) is currently not used in any tutorial. Should we add it to tut#1?

It was triggering some pylint errors so I have uncommented it for now.

Image

jannesgg commented 9 months ago

@victor-wildlife Sure, we could add this as a step in Tutorial 1. I just did not include it since it would allow users to mess with the projects_list.csv which is the master version of the projects. Perhaps we can discuss the best way to include this by for example adding error messages or limiting this usage to only certain authorized users.

victor-wildlife commented 9 months ago

I guess this will be mostly to add new projects in SNIC right? should we have a section in Tutorial 1 just to add projects in SNIC. I am thinking if this is something we won't use often maybe we can make a note of this function and how to use it in the documentation and just leave it uncommented?

jannesgg commented 9 months ago

@victor-wildlife I think that makes the most sense. We can describe the function and just warn users. Ultimately, this file is still version-controlled in the repo so it probably doesn't hurt even if people add or remove projects?