Closed Diewertje11 closed 9 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
I think that the python tests and CI are working as we expect.
The only 2 tings that I came across that are going wrong in the CI are:
But those things did not have anything to do with the changes in this PR. So if others have looked over it and don't see anything strange, it is ready to be merged.
I did not squash the commits, since we then need to wait for the CI checks again. But since the PR will squash it anyway and there are not that many if you look into the PR separate, I hope that this is not a problem.
This PR removes everything from the old submodule that is not the actual code, and puts the code directly in the first kso_utils folder.
Then it corrects all the references for imports. And the references in the CI pipeline.
Lastly it integrates the pylint check into the build-and-test-docker. This is because we want to run them in an updated container. And since the NB-tests already open this container, it is added as a step in this job so that we do not need to do any steps double.
The pylint tests are added as separate steps for the kso_utils, the tests and the tutorials, since we need a different package (nbqa) to do pylint on the jupyter notebooks. These 3 will always run (due to the if success/failure statement). However, the actual notebook and widgets tests will only run when the pylint tests have passed. They do not need to run if we have detected errors with pylint.