search

ocean-eddy-cpt / MOM6

Modular Ocean Model
Other
1 stars 1 forks source link

Fix units of *_visc_rem terms #13

Closed gustavo-marques closed 3 years ago

gustavo-marques commented 3 years ago

This patch fixes a unit inconsistency problem introduced in PR https://github.com/ocean-eddy-cpt/MOM6/pull/10. All *_visc_rem diagnostics terms were declared with units of m2 s-2 and the correct units should be m s-2 since visc_rem_u and visc_rem_v are non-dimensional.

codecov-commenter commented 3 years ago

Codecov Report

Merging #13 (5beb95c) into dev/cpt (7b3dd02) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 5beb95c differs from pull request most recent head 8ee65a6. Consider uploading reports for the commit 8ee65a6 to get more accurate results Impacted file tree graph

@@           Coverage Diff            @@
##           dev/cpt      #13   +/-   ##
========================================
  Coverage    29.29%   29.29%           
========================================
  Files          235      235           
  Lines        70799    70799           
========================================
  Hits         20742    20742           
  Misses       50057    50057
Impacted Files Coverage Δ
src/core/MOM_dynamics_split_RK2.F90 59.59% <100.00%> (ø)
src/parameterizations/lateral/MOM_hor_visc.F90 43.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b3dd02...8ee65a6. Read the comment docs.