search

ocean-eddy-cpt / MOM6

Modular Ocean Model
Other
1 stars 1 forks source link

(*) Merge dev/gfdl as of 06 Nov 2021 #18

Closed gustavo-marques closed 2 years ago

gustavo-marques commented 2 years ago

This PR includes changes from the latest main candidate NOAA-GFDL#1507. I also includes the new wind stress acceleration diagnostics introduced in https://github.com/NOAA-GFDL/MOM6/pull/1539.

Answers for the NW2 test are identical to those obtained before https://github.com/ocean-eddy-cpt/MOM6/pull/12

From July to October dev/gfdl was not correct (changing answers) and we incorrectly merged that into dev/cpt in August. The bug was in the initial topography and masking. It's a small detail in the topography that changes so no need to worry about science results - just not bitwise. This PR will bring the NW2 answers back to what they were prior to https://github.com/ocean-eddy-cpt/MOM6/pull/12

codecov-commenter commented 2 years ago

Codecov Report

Merging #18 (8b9d2d4) into dev/cpt (7868fdd) will decrease coverage by 0.14%. The diff coverage is 18.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           dev/cpt      #18      +/-   ##
===========================================
- Coverage    29.29%   29.15%   -0.15%     
===========================================
  Files          235      239       +4     
  Lines        70799    71533     +734     
===========================================
+ Hits         20742    20855     +113     
- Misses       50057    50678     +621
Impacted Files Coverage Δ
...g_src/drivers/solo_driver/MESO_surface_forcing.F90 0.00% <0.00%> (ø)
config_src/external/drifters/MOM_particles.F90 0.00% <0.00%> (ø)
...nfig_src/external/drifters/MOM_particles_types.F90 0.00% <0.00%> (ø)
src/ALE/MOM_regridding.F90 21.45% <0.00%> (+0.09%) :arrow_up:
src/ALE/coord_adapt.F90 0.00% <0.00%> (ø)
src/ALE/regrid_interp.F90 1.41% <ø> (ø)
src/core/MOM_PressureForce.F90 62.50% <ø> (+1.63%) :arrow_up:
src/core/MOM_PressureForce_Montgomery.F90 6.41% <0.00%> (+0.03%) :arrow_up:
src/core/MOM_grid.F90 61.68% <0.00%> (ø)
src/core/MOM_transcribe_grid.F90 24.63% <0.00%> (ø)
... and 167 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7868fdd...8b9d2d4. Read the comment docs.