search

ocean-eddy-cpt / MOM6

Modular Ocean Model
Other
1 stars 1 forks source link

Remove hard-wired parameter in adjustEtaToFitBathymetry #20

Closed gustavo-marques closed 2 years ago

gustavo-marques commented 2 years ago

In subroutine adjustEtaToFitBathymetry a hard-wired parameter (hTolerance = 0.1) controls the tolerance when adjusting the thickness to fit the bathymetry. This patch replaces hTolerance with a user-controlled parameter (THICKNESS_TOLERANCE). The latter is only activated when ADJUST_THICKNESS=True. To avoid change in answers, the default value of THICKNESS_TOLERANCE is 0.1 m. However, it remains to be tested whether this patch does not change answers.

In NW2, the hard-wired value (hTolerance = 0.1) leads to jumps (of ~ 0.1 m) in SSH between the prescribed values and the adjusted value in MOM_IC.nc.

image

This inconsistency is reduced when THICKNESS_TOLERANCE = 0.01 m:

image

codecov-commenter commented 2 years ago

Codecov Report

Merging #20 (70056f4) into dev/cpt (f81aa85) will decrease coverage by 0.00%. The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           dev/cpt      #20      +/-   ##
===========================================
- Coverage    29.15%   29.15%   -0.01%     
===========================================
  Files          239      239              
  Lines        71533    71538       +5     
===========================================
+ Hits         20855    20856       +1     
- Misses       50678    50682       +4
Impacted Files Coverage Δ
src/initialization/MOM_state_initialization.F90 20.73% <9.09%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f81aa85...70056f4. Read the comment docs.