Consolidating panels for Fig1

ocean-eddy-cpt / gcm-filters-paper

Manuscript on spatial filtering method

1 stars 0 forks source link

Consolidating panels for Fig1 #10

Closed jbusecke closed 3 years ago

jbusecke commented 3 years ago

Addressing #6

iangrooms commented 3 years ago

How can I view the new notebook? The diff is useless because it shows me the inner guts of the .ipynb files. I've not had to merge a PR on a jupyter notebook before...

rabernat commented 3 years ago

Indeed the notebook diff is useless.

https://www.reviewnb.com/ is a great tool for viewing notebook diffs in GitHub, but the free version doesn't work with private repos (like this one).

One thing you can do is just navigate directly the relevant file and view it via github: https://github.com/ocean-eddy-cpt/gcm-filters-paper/blob/88a82d4684c37ddb8e0aba461ebee74d659ff021/Fig1.ipynb

Doesn't show the diff, but you can at least review / approve the new version.

iangrooms commented 3 years ago

Perfect! I couldn't figure out how to get to the file itself, but I see now that I can just switch branches to look at it. Thanks @jbusecke ! I'll merge this and then add figure labels and get it into the manuscript next week.