search

ocean-eddy-cpt / gcm-filters-paper

Manuscript on spatial filtering method
1 stars 0 forks source link

Further tuning of Fig1 #15

Closed jbusecke closed 3 years ago

jbusecke commented 3 years ago

Towards #6

iangrooms commented 3 years ago

Thanks for the updates! One remaining thing: could you increase the width of the blue lines in all figures? The red line in many cases is so close to the blue line that it obscures it. I tried doing this using the "linewidth=4" option, but got some errors.

jbusecke commented 3 years ago

How about a dashed line instead? Here is a quick example of the first panel:

image
iangrooms commented 3 years ago

Looks good to me!

Ian

Sent from my phone

From: Julius Busecke notifications@github.com Sent: Wednesday, January 20, 2021 7:10:07 AM To: ocean-eddy-cpt/gcm-filters-paper gcm-filters-paper@noreply.github.com Cc: Ian Grooms Ian.Grooms@Colorado.EDU; Review requested review_requested@noreply.github.com Subject: Re: [ocean-eddy-cpt/gcm-filters-paper] Further tuning of Fig1 (#15)

How about a dashed line instead? Here is a quick example of the first panel: [image]https://user-images.githubusercontent.com/14314623/105186003-38245e80-5aff-11eb-8a23-1320a0542764.png

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/ocean-eddy-cpt/gcm-filters-paper/pull/15#issuecomment-763629951, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGGJIPMH5KJEHGUZRFPOD3TS23P37ANCNFSM4WJ7L33Q.

jbusecke commented 3 years ago

Ok I pushed the changes. I also had another small suggestion. I think it is easier to read the plots with some grid lines in the background:

image

This seems especially helpful to show where values actually go negative. The comand is simply ax.grid(). I put one example in there, you can either comment it out or apply it to all axes, depending on if you like it or not.

iangrooms commented 3 years ago

Looks great! Thanks again. I'll add the grid to the other panels on the main branch.