ocean-eddy-cpt / gcm-filters

Diffusion-based Spatial Filtering of Gridded Data
https://gcm-filters.readthedocs.io/
Other
37 stars 24 forks source link

Tripole boundary check does not pass on POP data #122

Closed NoraLoose closed 2 years ago

NoraLoose commented 2 years ago

While re-running the POP tripolar grid example (while working on PR #115) I noticed that the following "tripole" check does not pass for the POP grid data

https://github.com/ocean-eddy-cpt/gcm-filters/blob/7898c9cab7463de5d86bac95958239c0413a0a79/gcm_filters/kernels.py#L502-L509

As a result, running the tripolar grid notebook in the documentation gives an AssertionError. It seems like we haven't re-run that notebook since the check above was added.

I will try to get to the bottom of this later today.