Closed jbusecke closed 2 years ago
Merging #126 (0210d56) into master (75f172c) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 9 9
Lines 944 944
=======================================
Hits 929 929
Misses 15 15
Flag | Coverage Δ | |
---|---|---|
unittests | 98.41% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 75f172c...0210d56. Read the comment docs.
So if I comment out these lines the build succeeds. I am kind of confused why this would have not been an issue before switching to mamba.
Apparently I put it in there a while ago, but if the docs look OK I would just remove it?
Could someone go through the logs and the docs created for this PR and double check if the warnings can be ignored and if the docs look ok?
Thanks for this PR @jbusecke! I checked the docs, and they look ok. I'm not sure about the warnings in the logs. Probably ok to ignore them(?)
I would say so for now. Since its not part of the actual code, the docs output is all that matters, right?
Yes. I think we can merge this!
Would you have time to work on #120 with me next? It would be great to get your input there!
Quite tight on time today but I can definitely take a look!
Thanks! I didn't mean today, just whenever you have a chance. Just asking because from what you wrote in #120 you think that mamba can help over there. :)
Oh yes absolutely! Sorry for the misinterpretation.
Towards addressing problems in #120