search

ocean-eddy-cpt / gcm-filters

Diffusion-based Spatial Filtering of Gridded Data
https://gcm-filters.readthedocs.io/
Other
37 stars 24 forks source link

Factor gaussian example #130

Closed iangrooms closed 2 years ago

iangrooms commented 2 years ago

@NoraLoose was going to update several things about the examples, so we planned to have her update the numerical stability example notebook with the new factored Gaussian filter. Plans changed, so I put together this PR to add an example using the factored Gaussian to the numerical instability notebook. While doing it I made several minor updates to the example notebook, including a new comparison at the end between the results of filtering with double precision, with the factored Gaussian, and via coarsening. (Edit:) This is basically finishing off #127.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rabernat commented 2 years ago

This looks great Ian! I just read through the updated notebook and didn't catch any obvious issues. So I'll merge.