search

ocean-eddy-cpt / gcm-filters

Diffusion-based Spatial Filtering of Gridded Data
https://gcm-filters.readthedocs.io/
Other
37 stars 24 forks source link

Relax constraint on kappa grid variable #161

Closed NoraLoose closed 1 year ago

NoraLoose commented 1 year ago

The IRREGULAR_WITH_LAND takes kappa_w and kappa_s grid variables that allow to vary the filter scale spatially. There was a hard constraint on these kappas that they have to be equal to 1 somewhere in the domain. I softened the constraint to only checking that these kappas are very close to 1 somewhere in the domain (with a tolerance of 1e-05).

NoraLoose commented 1 year ago

This PR may solve issue #162, too.

iangrooms commented 1 year ago

Thanks @NoraLoose for noticing and fixing this, and thanks @marimpacheco for opening #162.