Resolve "Output format for ATT / VTrack usage" - [closed]

[jdpye]

In GitLab by @ryangosse on Jul 17, 2019, 15:15

Merges 83-output-format-for-att-vtrack-usage -> master

Closes #83

[jdpye]

In GitLab by @ryangosse on Jul 17, 2019, 15:18

added 1 commit

• 6f455c3e - Added function to convert glatos object to ATT object for VTrack

Compare with previous version

[jdpye]

In GitLab by @ryangosse on Jul 17, 2019, 15:18

assigned to @ryangosse

[jdpye]

In GitLab by @ryangosse on Jul 18, 2019, 10:24

added 2 commits

• e58690a5 - Added documentation to the glatos_to_att function and cleaned up some unused parts of that file
• d0eb6bf8 - Added .rd files for glatos_to_att and modified Readme to explain the new function

Compare with previous version

[jdpye]

In GitLab by @ryangosse on Aug 8, 2019, 09:29

added 1 commit

• ed63656d - Added function for converting OTN detections to the ATT format. Also cleaned...

Compare with previous version

[jdpye]

In GitLab by @ryangosse on Aug 8, 2019, 09:32

Seems to all be in order. 2 functions have been added: one for GLATOS detections and one for OTN detections with help from the OTN ERDDAP. The output from both seems to work with the functions provided in the ATT package. Handing off to Jon now for approval.

[jdpye]

In GitLab by @ryangosse on Aug 8, 2019, 09:32

unmarked as a Work In Progress

[jdpye]

In GitLab by @ryangosse on Aug 8, 2019, 09:32

assigned to @jdpye and unassigned @ryangosse

[jdpye]

In GitLab by @ryangosse on Aug 8, 2019, 10:08

added 1 commit

• a535c03c - Added namespaces to functions in the ATT conversion functions

Compare with previous version

[jdpye]

In GitLab by @jdpye on Sep 13, 2019, 16:09

Mitch Rider is attempting to use this branch now, so we have a real-world test cast out there.

[jdpye]

In GitLab by @jdpye on Sep 13, 2019, 16:10

assigned to @chrisholbrook and unassigned @jdpye

[jdpye]

In GitLab by @jdpye on Sep 13, 2019, 16:10

Gonna leave this with Holbrook for a minute because the next step is to get his review notes on this MR.

[jdpye]

In GitLab by @jdpye on Oct 4, 2019, 17:13

Hoping to use this in a workshop I'm gonna write later in October if it's functional. @chrisholbrook lemme know if you want me to kick tires more thoroughly.

[jdpye]

In GitLab by @chrisholbrook on Oct 4, 2019, 17:15

I will add the OTN sample data files and complete review next week.

[jdpye]

In GitLab by @chrisholbrook on Oct 11, 2019, 17:14

added 12 commits

• 6e826133 - change example object name to ATTdata to match VTrack examples
• 87fcc22b - formatting cleanup
• d8373656 - change input arg glatosObj to detectionObs to improve specificity
• f48a47bb - add test for convert_glatos_to_att output and add example walleye att internal...
• 41277955 - tweak formating (indents, spacing) for readability and consistency
• b06b1534 - add otn aat example data files from OTN ERDDAP
• 4dd67d85 - change name of input arg glatosObj to detectionObj for specificity
• 080454ea - map example code to example data files for otn aat erddap files
• af60aa05 - add blue shark att internal data set for testing
• 33f25966 - add test for convert otn erddap to att
• 62417c43 - tweak formatting for consistency and readability (indent, spacing)
• b5b2d973 - tweak formatting for consistency and readability (indent, spacing)

Compare with previous version

[jdpye]

In GitLab by @chrisholbrook on Oct 11, 2019, 17:29

@ryangosse @jdpye Please review and approve the changes I made today and I will close. My preference is to merge to dev then release to master because dev is also head of master. I will update NEWS and pkg help at that time to reflect changes in this MR.

Summary of changes I've made:

1. added otn_aat_animals.csv, otn_aat_receivers.csv, and otn_aat_tag_relases.csv to inst/extdata.
2. added internal data objects walleye_att and blue_shark_att containing the ATT objects for the walleye_detections and blue_shark_detections datasets; for unit testing.
3. added tests for convert_glatos_to_att (walleye/glatos data) and convert_otn_erddap_to_att (blue shark/otn data); simple check that ATT output from each function matches expectation.
4. for each function, changed input arg name "glatosObj" to "detectionObj" to reduce ambiguity.
5. modified documentation, including examples, and code to fix minor issues and to improve readability and consistency with other glatos functions.

[jdpye]

In GitLab by @ryangosse on Nov 4, 2019, 09:39

@chrisholbrook @jdpye Just read through the commits, seems good to me. Let's pull the trigger! Going to finish up the cran submission, get this thing out in the real world. Going to use master for that one.

[jdpye]

In GitLab by @chrisholbrook on Nov 7, 2019, 20:05

changes were merged with dev 722d2ed; will be included in release v. 0.4.0

[jdpye]

In GitLab by @chrisholbrook on Nov 7, 2019, 20:05

closed