Open mhpob opened 10 months ago
I dropped sp
back into the DESCRIPTION file, and talked it over with @chrisholbrook . We're gonna let sp
linger a while yet, since it's been updated to avoid the rgdal-apocalypse.
I will be working to make updates to the rest of the examples to replace the ones that use sp currently, as Todd's already done in a few places.
See #205 for a linger-er in convert_glatos_to_att
and data(walleye_att)
See #205 for a linger-er in
convert_glatos_to_att
anddata(walleye_att)
fixed in 503c394
sp is still imported globally in
R/package-glatos
, which errors out R CMD check.File: https://github.com/ocean-tracking-network/glatos/blob/dev/R/package-glatos.r#L117
Error: https://github.com/ocean-tracking-network/glatos/actions/runs/7427013555/job/20211890110#step:6:85
Could be a simple fix by removing it from
package-glatos
, but it could have big consequences if there are hidden functions still using it. Doesn't seem to have been addressed in the Todd no spatial PR, so it may not have been picked up in recent additions/checks.I might suggest removing
sp
frompackage-glatos
and putting it under Suggests in DESCRIPTION as some sp-using functions still exist (though are deprecated) and seeing what the downstream consequences are.