Closed mhpob closed 3 months ago
I support this change. FWIW, I usually go right to lubridate::fast_strptime()
; first version of read_glatos_detections()
would have likely used fasttime::fastPOSIXct
directly (hence why that's prevalent in docs); but I'm not sure why we went to parse_date_time
here instead of fast_strptime()
.
In the interest of one less dependency,
fasttime
was functionally baked intolubridate
in 2013 andlubridate
doesn't seem to have recognizedoption(lubridate.fasttime = TRUE)
since around that time, as well.Fix is simple: remove the lines below and drop
fasttime
fromDESCRIPTION
. Unfortunately, there's a lot of documentation that referencesfasttime::fastPOSIXct
that would require a bit more work.Benchmarks of the respective unit tests with and without the noted lines give the same result:
read_otn_detections
read_glatos_receivers
read_glatos_detections
read_otn_deployments
untested due to #202