search

ocean-tracking-network / glatos

9 stars 4 forks source link

Remove dependency on `units` #229

Closed mhpob closed 3 months ago

mhpob commented 6 months ago

Remove dependency on units introduced in a50334abe9ef813b2287bfea8f0371cf819ef36c. The same outcome as units::drop_units can be done by coercing to a matrix. Addresses one part of #122.

Running the examples in make_transition3 with and without units::drop_units result in identical objects:

> identical(ex1, ex1_nounits)
[1] TRUE
> identical(ex2, ex2_nounits)
[1] TRUE
> identical(ex3, ex3_nounits)
[1] TRUE

This PR gets glatos down to 20 explicit dependencies, which clears the R CMD check dependency note:

Current R CMD check failure is due to a floating point issue on macOS which will be fixed with acceptance of #228