search

ocean-transport / floater

For working with lagrangian float data
http://floater.readthedocs.io
15 stars 17 forks source link

Projection #45

Closed rabernat closed 7 years ago

rabernat commented 7 years ago

This PR adds the ability to specify lon and lat when identifying convex contours. The lon and lat are used to create local tangent plane projections when calculating contour area and convexity deficiency.

Partially fixes #17

codecov-io commented 7 years ago

Codecov Report

Merging #45 into master will increase coverage by 0.87%. The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   68.88%   69.76%   +0.87%     
==========================================
  Files           4        4              
  Lines         495      516      +21     
  Branches       80       84       +4     
==========================================
+ Hits          341      360      +19     
  Misses        128      128              
- Partials       26       28       +2
Impacted Files Coverage Δ
floater/rclv.py 81.98% <88%> (+1.27%) :arrow_up:
floater/utils.py 34.89% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 708e264...1be0c9a. Read the comment docs.

rabernat commented 7 years ago

@nathanieltarshish any comments before I merge? The syntax to use this is just

rclv.find_convex_contours(psi, lon=lon, lat=lat)