search

ocean-transport / floater

For working with lagrangian float data
http://floater.readthedocs.io
15 stars 17 forks source link

dimension_issue #55

Closed geosciz closed 7 years ago

geosciz commented 7 years ago

This pull request fixes the dimension issue of npart_to_2D_array. Instead of losing track of dimensions other than npart previously, the updated version is able to keep all dimension information documented in ds1d. This latest method is also included in floats_to_netcdf if the variable pkl_path is given.

cc: @rabernat

codecov-io commented 7 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.62%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   71.16%   71.78%   +0.62%     
==========================================
  Files           4        4              
  Lines         586      599      +13     
  Branches      106      108       +2     
==========================================
+ Hits          417      430      +13     
+ Misses        138      137       -1     
- Partials       31       32       +1
Impacted Files Coverage Δ
floater/generators.py 87.8% <100%> (+0.7%) :arrow_up:
floater/utils.py 36.18% <100%> (+1.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eca7ff...242d8eb. Read the comment docs.

rabernat commented 7 years ago

Wow this looks great @geosciz!

@nathanieltarshish, @anirban89...any comments before we merge?