search

ocean-transport / floater

For working with lagrangian float data
http://floater.readthedocs.io
15 stars 17 forks source link

accelerate_workflow #57

Closed geosciz closed 7 years ago

geosciz commented 7 years ago

This pull request modifies some expensive steps in npart_to_2D_array regarding dtype and pandas DataFrame, reducing the time cost of floater_convert from 2 minutes to 30 seconds per timestep. It also changes the names of the output coordinates from lat and lon to y0 and x0, respectively.

cc: @rabernat

codecov-io commented 7 years ago

Codecov Report

Merging #57 into master will increase coverage by 0.14%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   71.73%   71.88%   +0.14%     
==========================================
  Files           4        4              
  Lines         598      601       +3     
  Branches      108      108              
==========================================
+ Hits          429      432       +3     
  Misses        138      138              
  Partials       31       31
Impacted Files Coverage Δ
floater/generators.py 88.02% <100%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f771c0f...c2e4ac9. Read the comment docs.