search

ocean-transport / floater

For working with lagrangian float data
http://floater.readthedocs.io
15 stars 17 forks source link

read in column names from header #58

Closed nathanieltarshish closed 7 years ago

nathanieltarshish commented 7 years ago

This PR sets the float column names equal to the header in the float file. I have not changed the tests

nathanieltarshish commented 7 years ago

I am confused at to why test_npart_to_2D_array is failing on travis, but working when I pytest on my local machine. I also don't see the connection between test_npart_to_2D_array and this PR. @rpa would you please help clarify?

geosciz commented 7 years ago

Yes. I fetched this pull request into my local branch and it passed pytest. According to Travis CI, it is framei.loc[ocean_bools==True] = dast.astype(np.float32) that causes the fail.

cc: @rabernat, @nathanieltarshish

rabernat commented 7 years ago

The specific error is:

ValueError: cannot set using a list-like indexer with a different length than the value

This implies that ocean_bools and dast do not have the same length.

Since we are eager to move forward and the test is passing for you both locally, I am ok with merging this and having @geosciz fix the test via a separate PR.

We also need a new test of the new feature added by this PR. Normally I would insist that @nathanieltarshish add this here, but again, perhaps we should just move on and not be so obsessed about the tests...