ocean-transport / floater

For working with lagrangian float data

http://floater.readthedocs.io

15 stars 17 forks source link

read_header #59

Closed geosciz closed 7 years ago

rabernat commented 7 years ago

Could the failing test be related to the pandas version? https://travis-ci.org/rabernat/floater/jobs/242245642#L325

It's 0.20 on travis. What version of pandas do you have locally?

geosciz commented 7 years ago

@rabernat 0.19.2

geosciz commented 7 years ago

@rabernat I agree it's pandas version issue. See this line: https://travis-ci.org/rabernat/floater/jobs/242245642#L563. The problem does not originate from the code inside floater, but from something internally in core directory of pandas. In the test, I create an index ranging from 1 to 81, however, indexer variable here (created by pandas internally): https://travis-ci.org/rabernat/floater/jobs/242245642#L574 ranges from 1 to 80.

rabernat commented 7 years ago

@geosciz I think you might need to rebase your branch.

rabernat commented 7 years ago

Does this pass your local tests as well?

geosciz commented 7 years ago

@rabernat I updated pandas and it passed my local test.

rabernat commented 7 years ago

Look at these tests: https://travis-ci.org/rabernat/floater

rabernat commented 7 years ago

If you rebase again, you will get my new test maxtrix

codecov-io commented 7 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.25%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage    71.8%   72.06%   +0.25%     
==========================================
  Files           4        4              
  Lines         603      605       +2     
  Branches      109      109              
==========================================
+ Hits          433      436       +3     
  Misses        138      138              
+ Partials       32       31       -1

Impacted Files	Coverage Δ
floater/utils.py	`37.82% <100%> (+1.45%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 47c6c50...69de2cd. Read the comment docs.

rabernat commented 7 years ago

I know you have been working on this a long time and are eager to finish it off.

But why don't we just add the test data with headers to this PR? It really belongs here.

geosciz commented 7 years ago

@rabernat No problem. I am going to add the test data today.