ocean-transport / floater

For working with lagrangian float data
http://floater.readthedocs.io
15 stars 17 forks source link

Some additions to allow float profiling #75

Closed cspencerjones closed 4 years ago

cspencerjones commented 5 years ago

These changes make it possible to read and write profiling floats. If we actually want these changes I can write some basic tests for the generators changes before you merge - let me know!

cspencerjones commented 5 years ago

I find that this test fails even on the master branch (without the changes in this pull request). Any suggestions for how to deal with this?

rabernat commented 5 years ago

Thanks Spencer!

It would be good to have some very basic test, just to ensure that the new options actually do something.

The failing test involves the bcolz output option. I wouldn't worry about it. That is not widely used.

cspencerjones commented 4 years ago

Can we maybe merge this?