search

ocean-transport / scale-aware-air-sea

Repo for collaborative project on scale-aware air-sea fluxes
2 stars 0 forks source link

Lock down pushes to main? #3

Closed jbusecke closed 2 years ago

jbusecke commented 2 years ago

I think we should prevent pushes to the main branch directly and handle everything via PRs? Makes for a more transparent way of discussion changes.

Any objections @ocean-transport/collab_team ?

cisaacstern commented 2 years ago

Makes sense to me!

jbusecke commented 2 years ago

Oh it seems that this is a paid feature now...

image

...at least for private repos.

Then let me add another question. Would anyone be opposed to making this repo public?

paigem commented 2 years ago

I don't mind if the repo is public or private. For now I'm happy to not push anything directly to the main branch.

This may be something we want to clarify: how we manage PRs and other repo updates. Who should approve and click "Merge" on the PRs? Do the same steps apply for updating markdown files (e.g. the README or literature files)?

(FYI I just pushed some updates to the README straight to main... 😬)

jbusecke commented 2 years ago

There is an option to specify the number of reviews needed, but we could give admins the ability to merge even if these are not given (useful for very small and trivial changes). That way its more a reminder, rather than a hard restriction?

jbusecke commented 2 years ago

Closing it for now, since pushes to main are nice for literature updates.