search

ocean-transport / scale-aware-air-sea

Repo for collaborative project on scale-aware air-sea fluxes
1 stars 0 forks source link

Add weighted coarsen function #52

Closed jbusecke closed 1 year ago

jbusecke commented 1 year ago

I made a prototype of a weighted coarsen function for out workflow and added some tests.

For our purposes I had to restrict this to dataset where all variables have missing values in the exact same position, and where the weights (area usually) has zeros in those same locations, otherwise errors are raised.

I discovered some weird issue that I traced down to something to do with the precision of the weights, but could not reproduce with a simple example. I kept it in notebooks/jbusecke/issue_weighted_mean_precision.ipynb.

Some initial can be found in notebooks/jbusecke/dev_weighted_coarsen.ipynb.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jbusecke commented 1 year ago

Oh I just realized we have absolutely no CI for this repo...I shall do that first.