oceanbase / miniob

MiniOB is a compact database that assists developers in understanding the fundamental workings of a database.
https://oceanbase.github.io/miniob/
Mulan Permissive Software License, Version 2
3.41k stars 1.22k forks source link

[BUG]memory leak during parser and parser improvement #308

Open AMOSOMNUM opened 12 months ago

AMOSOMNUM commented 12 months ago

All happen in src/observer/sql/parser/yacc.sql.y.

  1. memory leak

    Line 374-value: $1 should be freed.

Line 402-update_stmt: $6 should be deleted.

  1. parser improvement use left recursion for better performance and remove silly vector reverse!!!
hnwyllmm commented 12 months ago

Thanks for you advices.