search

oceanbit / GitShark

🦈 A Git client to surf through your repos on mobile
https://gitshark.dev
Mozilla Public License 2.0
136 stars 9 forks source link

Some dark mode text is black on dark blue #42

Closed evelynhathaway closed 4 years ago

evelynhathaway commented 4 years ago

Details: Android 10, System Dark Mode, Dark Mode to Auto or Dark

Screenshots ![photo_2020-08-08_10-23-00](https://user-images.githubusercontent.com/38994283/89716367-31df6300-d961-11ea-9b38-cb943899bfdb.jpg) Commit title, SHA, REF, PAR ![photo_2020-08-08_10-23-02](https://user-images.githubusercontent.com/38994283/89716368-3277f980-d961-11ea-9a32-852d7f165d5f.jpg) Logged in user
evelynhathaway commented 4 years ago

Ohh, you're right! I also got it to occur in light mode with system dark (and not system light).

Screenshots ![photo_2020-08-08_10-29-39](https://user-images.githubusercontent.com/38994283/89716464-13c63280-d962-11ea-895e-647ea7b943ab.jpg) FAB
crutchcorn commented 4 years ago

Note for myself:

This is the primary bug that's being reported by alpha testers. During initial investigation, it appears to be a mismatch between the DynamicValue in context and that initial value that's set by the system.

One of the theories I had is that this was a bug in the DarkMode provider, but even updating to React Native 0.63.0 and react-native-dynamic had no effect on fixing this. This makes me think that either the bug persisted across package upgrades, or there's some issue with how we're nesting these specific components.