search

oceanbit / GitShark

🦈 A Git client to surf through your repos on mobile
https://gitshark.dev
Mozilla Public License 2.0
135 stars 9 forks source link

Commit details page does not list all changed files #45

Closed crutchcorn closed 3 years ago

crutchcorn commented 4 years ago

I've noticed that sometimes, while the commit details page

This is due to getFileStateChanges somehow not listing all of the changed files. As such, we'll be migrating to use jGit:

https://stackoverflow.com/questions/28785364/list-of-files-changed-between-commits-with-jgit/28793479

https://github.com/maks/MGit/blob/master/app/src/main/java/me/sheimi/sgit/repo/tasks/repo/CommitDiffTask.java

crutchcorn commented 4 years ago

1) Create a getFileStateChanges-android.ts file in /src/services/git 2) Add a Platform.OS === 'android' check in /src/services/git/getFileStateChanges.ts 3) Add new getFileStateChanges method to /android/.../GitModule.java 4) Add the NativeModule call to the Android call 5) Test to make sure this works (do this by cloning a project, then opening the project, go to commit list, click on a commit, make sure that all of the files that were changed in that commit are listed (check against GitHub repo))