search

oceanhackweek / jupyter-image

jupyter-image
MIT License
2 stars 7 forks source link

test installing extra r pkgs #3

Closed ocefpaf closed 4 years ago

ocefpaf commented 4 years ago

Fingers crossed!

ocefpaf commented 4 years ago

OK. This passed! Let's merge and create a new image.

@salvis2 can you refresh the hub later with the new image that has these changes?

salvis2 commented 4 years ago

The hub should find the new image whenever someone logs in after the image is live!

ocefpaf commented 4 years ago

I thought we need to something in https://github.com/oceanhackweek/ohw-jupyterhub-2020 to make it pull the new image. I tested and it loaded the old one instead of the latest one in https://hub.docker.com/repository/docker/uwhackweeks/oceanhackweek/tags?page=1

PS: now the tag is latest instead of master :smile: We probably need to revert that change I made, right?

salvis2 commented 4 years ago

I thought we need to something in https://github.com/oceanhackweek/ohw-jupyterhub-2020 to make it pull the new image. I tested and it loaded the old one instead of the latest one in https://hub.docker.com/repository/docker/uwhackweeks/oceanhackweek/tags?page=1

PS: now the tag is latest instead of master 😄 We probably need to revert that change I made, right?

It currently references latest: https://github.com/oceanhackweek/ohw-jupyterhub-2020/blob/staging/deployments/ohw-hub/config/prod.yaml#L14 but I can confirm logging in as well that it does not have the new packages. Maybe we should just have manual tags, like 12727c6. What do you think?

ocefpaf commented 4 years ago

It currently references latest: oceanhackweek/ohw-jupyterhub-2020@staging/deployments/ohw-hub/config/prod.yaml#L14

Ah yes. Your commit fixed that.

but I can confirm logging in as well that it does not have the new packages. Maybe we should just have manual tags, like 12727c6. What do you think?

Whatever works. Not sure why we get both. Also, those are not "manual," right? I believe they get the sha from the commit, no? (Sorry for all these questions. It is a new workflow or me.)

salvis2 commented 4 years ago

Whatever works. Not sure why we get both. Also, those are not "manual," right? I believe they get the sha from the commit, no?

I think both of these are correct. I think ICESat-2 had GitHub actions to make new tags on DockerHub whenever we made a tag in the GitHub repo. Maybe just waiting a bit will make the JupyterHub realize there is a new image.

ocefpaf commented 4 years ago

Maybe just waiting a bit will make the JupyterHub realize there is a new image.

Yep. That is the part I'm confused :smile:

salvis2 commented 4 years ago

I'll check a few times tonight and see if it grabs the new image. Otherwise I'll switch it to manual tags and try that.

salvis2 commented 4 years ago

Checked just now and I'm not seeing the new packages. Will switch to manual tags tomorrow.

salvis2 commented 4 years ago

@ocefpaf it looks like the new packages are there now. Just took maybe a day for the hub to check and find the new image.

ocefpaf commented 4 years ago

Yep. Just tested them. Thanks!

R-debug