search

oceanhackweek / ohw22-proj-gcmfilters

Mapping eddy flow structures using GCM-Filters
1 stars 4 forks source link

Adding my notebook #8

Closed leticiafabre closed 2 years ago

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

NoraLoose commented 2 years ago

@leticiafabre really nice notebook! I left some minor suggestions and comments on the notebook. I think you can see the comments best if you click the purple "ReviewNB" button in the comment above.

NoraLoose commented 2 years ago

The notebook looks great @leticiafabre! I have just one little suggestion:

Before the cell where you make all the figures (for the movie), you could insert one cell that just makes one figure for a single time slice. The figure would then show up in the jupyter notebook, and you could talk about it a little bit during the presentation. Then you can move to the next cell, and say: "Now we repeat this to make this figure for many time slices, which we then stitch together to a movie with ffmpeg." Then you can switch over to GitHub and show the movie.

NoraLoose commented 2 years ago

This notebook looks great @leticiafabre. I am merging this PR.