Bug: Using flight roll not gimbal in re projection test

oceanhackweek / ohw23_proj_drone_georef

We aim to develop a workflow to match drone images with a satellite grid

Apache License 2.0

1 stars 0 forks source link

Bug: Using flight roll not gimbal in re projection test #9

Open NickMortimer opened 1 year ago

NickMortimer commented 1 year ago

It looks like we have a small bug? XMP:FlightRollDegree is being renamed Gimbal roll. Gimbal roll is usually 0 degrees!

gimbal_angles = df_meta[['XMP:GimbalYawDegree', 'XMP:GimbalPitchDegree', 'XMP:FlightRollDegree','XMP:RelativeAltitude']] gimbal_angles = gimbal_angles.rename(columns={'XMP:RelativeAltitude':'UAV_Altitude', 'XMP:GimbalYawDegree':'Gimbal_Yaw', 'XMP:GimbalPitchDegree':'Gimbal_Pitch', 'XMP:FlightRollDegree':'Gimbal_Roll'})

pbranson commented 1 year ago

Good pick-up Nick, you are correct!

I have fixed that in d6afd6e5c05d5eb7c0b67565c6ba6cbf9fecea3d