search

oceanmodeling / Management

Followup-tasks
Creative Commons Zero v1.0 Universal
0 stars 1 forks source link

Pre-commit configuration #10

Closed brey closed 2 years ago

brey commented 2 years ago

It seems that all repos in the organisation need a .pre-commit-config.yaml by default or commits will get an "x".

  1. How this was setup? (good to know)

  2. Should we drop the requirement for this repo or have a default configuration that can be used across all repos?

@zacharyburnett @pmav99

pmav99 commented 2 years ago

pre-commit is a framework that allows you install and run pre-configured git hooks (including your own). It is really useful for development since it ensures that all commits adhere to a minimum of code standards.

The creator of pre-commit, also created a CI service which is offered for free for open source projects. The services is offered under https://pre-commit.ci It is from this service that we get that red "x".

I don't have admin rights here, so I guess that it was @zacharyburnett that configured it. Or I asked you to do it for me at some point. I don't remember. Anyhow, you should be able to disable it. Visit this page and configure pre-commit just for the repos that use it: https://github.com/apps/pre-commit-ci/

brey commented 2 years ago

So @pmav99 you suggest we keep it only for some repos?

pmav99 commented 2 years ago

yeah. For now just searvey should do it.

brey commented 2 years ago

Done. Configured only for searvey.