search

oceanmodeling / StormEvents

Python interfaces for observational data surrounding named storm events, born from @jreniel's ADCIRCpy
https://stormevents.readthedocs.io
GNU General Public License v3.0
22 stars 8 forks source link

`OFCL` correction by `CARQ` doesn't work for non-empty `0` fields #64

Closed SorooshMani-NOAA closed 1 year ago

SorooshMani-NOAA commented 1 year ago

Some fields in the original ATCF file's OFCL track don't have valid data, but they are not either empty or NA. For example see the pressure field below:

AL, 06, 2018091306, 03, OFCL,   0, 325N,  743W,  95,    0, HU,  34, NEQ,  170,  150,  110,  140,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  14,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,   0, 325N,  743W,  95,    0, HU,  50, NEQ,  100,   90,   70,   80,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  14,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,   0, 325N,  743W,  95,    0, HU,  64, NEQ,   70,   60,   50,   60,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  14,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,   3, 328N,  747W,  95,  956, HU,  34, NEQ,  170,  150,  110,  140,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  13,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,   3, 328N,  747W,  95,  956, HU,  50, NEQ,  100,   90,   70,   80,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  13,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,   3, 328N,  747W,  95,  956, HU,  64, NEQ,   70,   60,   50,   60,    0,    0,   0, 115,   0,    ,   0, DPB, 315,  13,           ,  , 12, NEQ,  330,  240,  240,  300, 
AL, 06, 2018091306, 03, OFCL,  12, 337N,  761W,  95,    0, HU,  34, NEQ,  170,  150,  110,  130,    0,    0,   0, 115,   0,    ,   0, DPB, 310,  10, 
AL, 06, 2018091306, 03, OFCL,  12, 337N,  761W,  95,    0, HU,  50, NEQ,  100,   90,   70,   80,    0,    0,   0, 115,   0,    ,   0, DPB, 310,  10, 
AL, 06, 2018091306, 03, OFCL,  12, 337N,  761W,  95,    0, HU,  64, NEQ,   70,   60,   50,   60,    0,    0,   0, 115,   0,    ,   0, DPB, 310,  10,

StormEvents only corrects the fields based on CARQ if the field is NA: https://github.com/oceanmodeling/StormEvents/blob/2895957d5ea6bff6f4f57ede3153941adcdbf41e/stormevents/nhc/track.py#L1007-L1009

This needs to be updated so that OFCL tracks are correctly updated by the logic implemented at: https://github.com/oceanmodeling/StormEvents/blob/2895957d5ea6bff6f4f57ede3153941adcdbf41e/stormevents/nhc/track.py#L979-L980