Closed FariborzDaneshvar-NOAA closed 7 months ago
@FariborzDaneshvar-NOAA can you please merge bugfix/test_ref
to this branch? The test failure is due to an issue with test reference. The USGS response for a past storm has been updated. I added the updated ref file in that branch, please get the change and see if the test go through. Thanks!
@FariborzDaneshvar-NOAA can you please merge
bugfix/test_ref
to this branch? The test failure is due to an issue with test reference. The USGS response for a past storm has been updated. I added the updated ref file in that branch, please get the change and see if the test go through. Thanks!
@SorooshMani-NOAA I cannot make a pull request to merge bugfix/test_ref
to default_coops_datum
. Please correct me if I'm wrong, thanks.
@SorooshMani-NOAA I executed the following commands to merge bugfix/test_ref
with default_coops_datum
, but got this message: Already up-to-date.
git fetch --all
git checkout bugfix/test_ref
git checkout default_coops_datum
git merge bugfix/test_ref
Please let me know if there is something I'm missing. thanks
@FariborzDaneshvar-NOAA sorry I realized I hadn't pushed the test ref changes to that branch remote!! Please fetch again and do the same as what you did, you should now get the test update (.csv
files). Sorry about that!
@SorooshMani-NOAA Thanks!
Fast-forward
tests/data/reference/test_usgs_flood_events/events.csv | 4 ++--
tests/data/reference/test_usgs_flood_storms/storms.csv | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
@pmav99 can you help me figure out what's going on with the CodeCov here? I don't understand why it fails!
@pmav99 I'd appreciate it if you could take a look at this PR too to see why the coverage gets cancelled?
No idea really. Try to disable the -n auto
to see what happens
@FariborzDaneshvar-NOAA the code in this repo is styled using
black
. Please install it and format the file you updated. Thank you!