Historical NDBC stations

oceanmodeling / searvey

Sea state observational data retrieval

https://searvey.readthedocs.io/en/stable/

GNU General Public License v3.0

24 stars 11 forks source link

Historical NDBC stations #161

Open SorooshMani-NOAA opened 2 months ago

SorooshMani-NOAA commented 2 months ago

In #146 historical stations are not yet implemented. See:

https://github.com/CDJellen/ndbc-api/blob/a4786307869d753e07c3413f1e1c0cf47f418ea2/ndbc_api/ndbc_api.py#L256

tomsail commented 2 months ago

I had a look on the faq: https://www.ndbc.noaa.gov/faq/measdes.shtml:

Realtime (the current implementation) is limited to the last 45days.
Historical is older than 45days

It seems we can get both data with get_data() function in NDBCApi.

SorooshMani-NOAA commented 2 months ago

Yes, but the station list that we get right now is only from the active stations, not the historical ones (stations vs historical_stations).

SorooshMani-NOAA commented 2 months ago

Some of these capabilities are very recently added to the upstream NDBC_API code, so it requires the latest version of API to work. So maybe it makes sense to go ahead with #146 first and later address this ticket. Previously (since 2 weeks ago?) there was a single stations query that addressed both!

tomsail commented 2 months ago

ok indeed. I think then it'd make sense to pin/limit the version of NDBCApi and merge #146

SorooshMani-NOAA commented 2 months ago

Yes, it's already pinned