oceanmodeling / searvey

Sea state observational data retrieval
https://searvey.readthedocs.io/en/stable/
GNU General Public License v3.0
23 stars 11 forks source link

missing module for NDBC stations #167

Open carolakaiser opened 2 weeks ago

carolakaiser commented 2 weeks ago

I have installed the latest searvey version via pip using Python 3.12 This installs searvey 0.3.14. When testing the NDBC_data.ipynb, I get a module error: image I verified in the searvey package directory that the module _ndbc_api is missing -- support is appreciated.

tomsail commented 2 weeks ago

Hi @carolakaiser,

indeed release 0.3.14 was done before the merge of NDBC please try:

pip install git+https://github.com/oceanmodeling/searvey.git
carolakaiser commented 1 week ago

Hi @tomsail Thank you, I installed as suggested. Please see below what I get now:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[4], [line 7](vscode-notebook-cell:?execution_count=4&line=7)
      [4](vscode-notebook-cell:?execution_count=4&line=4) import hvplot.pandas
      [5](vscode-notebook-cell:?execution_count=4&line=5) import pandas as pd
----> [7](vscode-notebook-cell:?execution_count=4&line=7) from searvey._ndbc_api import fetch_ndbc_station,get_ndbc_stations,_fetch_ndbc
      [8](vscode-notebook-cell:?execution_count=4&line=8) logging.basicConfig(
      [9](vscode-notebook-cell:?execution_count=4&line=9)     level=20,
     [10](vscode-notebook-cell:?execution_count=4&line=10)     style="{",
     [11](vscode-notebook-cell:?execution_count=4&line=11)     format="{asctime:s}; {levelname:8s}; {threadName:23s}; {name:<25s} {lineno:5d}; {message:s}",
     [12](vscode-notebook-cell:?execution_count=4&line=12) )
     [14](vscode-notebook-cell:?execution_count=4&line=14) logging.getLogger("urllib3").setLevel(30)

File c:\work\Tutorials\searvey\.venv\Lib\site-packages\searvey\__init__.py:7
      [5](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/__init__.py:5) from searvey._coops_api import fetch_coops_station
      [6](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/__init__.py:6) from searvey._ioc_api import fetch_ioc_station
----> [7](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/__init__.py:7) from searvey._ndbc_api import fetch_ndbc_station
      [8](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/__init__.py:8) from searvey._ndbc_api import get_ndbc_stations
      [9](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/__init__.py:9) from searvey.coops import get_coops_stations

File c:\work\Tutorials\searvey\.venv\Lib\site-packages\searvey\_ndbc_api.py:11
      [9](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/_ndbc_api.py:9) import numpy as np
     [10](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/_ndbc_api.py:10) import pandas as pd
---> [11](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/_ndbc_api.py:11) from ndbc_api import NdbcApi
     [12](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/_ndbc_api.py:12) from shapely.geometry import MultiPolygon
     [13](file:///C:/work/Tutorials/searvey/.venv/Lib/site-packages/searvey/_ndbc_api.py:13) from shapely.geometry import Polygon

ModuleNotFoundError: No module named 'ndbc_api'

Thank you.

pmav99 commented 1 week ago

This is because you are missing this package which is a dependency: https://github.com/djtimca/ndbc-api