oceanmodeling / seaset

Sea relevant Observational sources Dataset
1 stars 3 forks source link

Last version of Updated_Catalog might discard too many stations #8

Open tomsail opened 1 year ago

tomsail commented 1 year ago

There is a problem in discarding stations that have same set of lat/lon or too close to each other. Some - not exhaustive - reasons

  1. some stations may have had multiple deployments over time, from the same or different providers and are identified with different names
  2. some might have different ioc_codes but be the same station with different instruments (ex: sete and sete2).

https://github.com/oceanmodeling/seaset/blob/main/Notebooks/Updated_Catalog.ipynb

I suggest to:

tomsail commented 6 months ago

Update on this: the same problem was seen when analyzing results from models and observed data from ioc_cleanup (for prin and prin2 stations)

Actions suggested:

pmav99 commented 6 months ago

Assuming that seaset is a GeoDataFrame (or at least a DataFrame with lon/lat columns), then we should think carefully which functions are really needed, because some of them are trivial to implement. For example get_coords(id) is just seaset[seaset.id==id].geometry or similar,